Skip to content

Fix #250737, Match count result overflow in Notebook findWidget #250738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

yiliang114
Copy link
Contributor

Before fix:
image

After fix:
image

I saw that the minWidth here was modified in this #147398 . Now after revising back to the minWidth, it seems that there won't be any problems now either.

@yiliang114
Copy link
Contributor Author

hi, @osortega Can you help me review the code?

@osortega osortega assigned Yoyokrazy and unassigned osortega Jun 9, 2025
Copy link
Collaborator

@Yoyokrazy Yoyokrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the community PR! This looks good to me 👍

With the additional CSS that was brought in via the earlier PR you mentioned, and (somewhat) recent changes to the starting width of the notebook find widget, this seems like a good fix.

@Yoyokrazy Yoyokrazy enabled auto-merge (squash) June 10, 2025 14:42
@vs-code-engineering vs-code-engineering bot added this to the June 2025 milestone Jun 10, 2025
@Yoyokrazy Yoyokrazy merged commit b35b527 into microsoft:main Jun 10, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants