Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with snippet choices escaping #169287

Merged
merged 3 commits into from Dec 15, 2022
Merged

Fix bug with snippet choices escaping #169287

merged 3 commits into from Dec 15, 2022

Conversation

pokey
Copy link
Contributor

@pokey pokey commented Dec 15, 2022

The code that inserts \ to escape text in choices in toTextmateString wasn't escaping \ characters themselves. Fwiw this bug could have been caught by codeql

@pokey
Copy link
Contributor Author

pokey commented Dec 15, 2022

@microsoft-github-policy-service agree

Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY

@jrieken jrieken added this to the January 2023 milestone Dec 15, 2022
@jrieken jrieken merged commit 3375e50 into microsoft:main Dec 15, 2022
6 checks passed
@pokey pokey deleted the patch-2 branch December 15, 2022 18:12
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants