Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk/overlay): not setting correct opacity in high contrast mode on Firefox #21896

Merged

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 13, 2021

The backdrop styles were never switches to the cdk-high-contrast mixin which means that they won't work on Firefox. These changes switch to using the mixin and update the docs.

Fixes #21890.

@crisbeto crisbeto added P3 a11y G target: patch labels Feb 13, 2021
@crisbeto crisbeto requested review from jelbourn and as code owners Feb 13, 2021
@google-cla google-cla bot added the cla: yes label Feb 13, 2021
…n Firefox

The backdrop styles were never switches to the `cdk-high-contrast` mixin which means that
they won't work on Firefox. These changes switch to using the mixin and update the docs.

Fixes angular#21890.
@crisbeto crisbeto force-pushed the 21890/background-high-contrast-firefox branch from fcf7ea3 to c457d18 Compare Feb 13, 2021
Copy link
Member

@josephperrott josephperrott left a comment

LGTM

@crisbeto crisbeto added the merge ready label Feb 16, 2021
Copy link
Member

@jelbourn jelbourn left a comment

LGTM

@andrewseguin andrewseguin merged commit 4b8427e into angular:master Feb 18, 2021
16 checks passed
andrewseguin pushed a commit that referenced this issue Feb 18, 2021
…n Firefox (#21896)

The backdrop styles were never switches to the `cdk-high-contrast` mixin which means that
they won't work on Firefox. These changes switch to using the mixin and update the docs.

Fixes #21890.

(cherry picked from commit 4b8427e)
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 26, 2021
… shorthand path

Fixes a regression caused by angular#21896 where importing the overlay styles through
`~@angular/cdk/overlay` would result in a compilation error.
wagnermaciel pushed a commit that referenced this issue Mar 2, 2021
… shorthand path (#22043)

Fixes a regression caused by #21896 where importing the overlay styles through
`~@angular/cdk/overlay` would result in a compilation error.
wagnermaciel pushed a commit to wagnermaciel/components that referenced this issue Mar 2, 2021
… shorthand path (angular#22043)

Fixes a regression caused by angular#21896 where importing the overlay styles through
`~@angular/cdk/overlay` would result in a compilation error.
wagnermaciel added a commit that referenced this issue Mar 2, 2021
… shorthand path (#22043) (#22086)

Fixes a regression caused by #21896 where importing the overlay styles through
`~@angular/cdk/overlay` would result in a compilation error.

Co-authored-by: Kristiyan Kostadinov <crisbeto@users.noreply.github.com>
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Mar 21, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11y cla: yes G merge ready P3 target: patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants