practicalswift
Follow
Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign up
Pinned
633 contributions in the last year
Activity overview
Contribution activity
November 2020
Created 21 commits in 3 repositories
Created a pull request in bitcoin/bitcoin that received 3 comments
fuzz: Check for addrv1 compatibility before using addrv1 serializer/deserializer on CService
Check for addrv1 compatibility before using addrv1 serializer/deserializer on CService:
Before this patch:
$ src/test/fuzz/service_deserialize
serv…
+4
−1
•
3
comments
Opened 12 other pull requests in 2 repositories
bitcoin/bitcoin
4
open
7
merged
- util: Avoid invalid integer negation in FormatMoney and ValueFromAmount
- Avoid signed integer overflow and invalid integer negation when loading malformed mempool.dat files
- doc: Add instructions on how to fuzz the P2P layer using Honggfuzz NetDriver
- tests: Remove no longer needed UBSan suppression (float divide-by-zero in validation.cpp)
- fuzz: Fill various small fuzzing gaps
- fuzz: Improve coverage for CPartialMerkleTree fuzzing harness
- Avoid signed integer overflow when loading a mempool.dat file with a malformed time field
- fuzz: Check for addrv1 compatibility before using addrv1 serializer/deserializer on CSubNet
- fuzz: Assert expected DecodeHexTx behaviour when using legacy decoding
- net: Make it easier to reason about node eviction by removing unused NodeEvictionCandidate::addr (CAddress)
- fuzz: Fix DecodeHexTx fuzzing harness issue
bitcoin-core/qa-assets
1
merged
Reviewed 1 pull request in 1 repository
bitcoin/bitcoin 1 pull request
Created an issue in bitcoin/bitcoin that received 1 comment
Invalid integer negation in FormatMoney(CAmount n) and ValueFromAmount (CAmount n) when n = std::numeric_limits<CAmount>::min()
FormatMoney(CAmount n) is not being properly defined for n = std::numeric_limits<CAmount>::min(). This is due to an invalid integer negation: the n…
1
comment