Skip to content

/ install

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install: Return rosetta advice on arm64 macOS #349

Merged
merged 2 commits into from Nov 16, 2020
Merged

install: Return rosetta advice on arm64 macOS #349

merged 2 commits into from Nov 16, 2020

Conversation

@roolebo
Copy link
Contributor

@roolebo roolebo commented Nov 15, 2020

Current version of installer prints a terse error on DTK:

Homebrew is only supported on Intel processors!

Fixes: 8f22b74 ("install: recommend Rosetta only on macOS")
@roolebo
install: Return rosetta advice on arm64 macOS
Loading status checks…
31ca11a 
Current version of installer prints a terse error on DTK:

  Homebrew is only supported on Intel processors!

Fixes: 8f22b74 ("install: recommend Rosetta only on macOS")
@roolebo roolebo force-pushed the roolebo:readd-warning-on-arm-macs branch from 23b2372 to 31ca11a Nov 15, 2020
@MikeMcQuaid
MikeMcQuaid reviewed Nov 16, 2020
View changes
install.sh Outdated Show resolved Hide resolved
@MikeMcQuaid
install.sh: still abort on PPC Macs.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cb6aa2c
@MikeMcQuaid MikeMcQuaid merged commit 2bc90b9 into Homebrew:master Nov 16, 2020
2 checks passed
2 checks passed
tests (macOS-latest)
Details
tests (ubuntu-latest)
Details
@MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Nov 16, 2020

Thanks @roolebo!
@roolebo roolebo deleted the roolebo:readd-warning-on-arm-macs branch Nov 16, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid

Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@roolebo @MikeMcQuaid @BrewTestBot
You can’t perform that action at this time.