API with Express & Handlebar Templates #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodion-arr
suggested changes
Oct 15, 2020
servers/express/api-with-express-and-handlebar/controllers/appController.js
Outdated
Show resolved
Hide resolved
servers/express/api-with-express-and-handlebar/controllers/appController.js
Outdated
Show resolved
Hide resolved
servers/express/api-with-express-and-handlebar/routes/routes.js
Outdated
Show resolved
Hide resolved
servers/express/api-with-express-and-handlebar/test/nock-data.json
Outdated
Show resolved
Hide resolved
servers/express/api-with-express-and-handlebar/views/layout.hbs
Outdated
Show resolved
Hide resolved
Co-authored-by: Rodion Abdurakhimov <rodion-arr@users.noreply.github.com>
bnb
reviewed
Oct 15, 2020
bnb
reviewed
Oct 15, 2020
bnb
reviewed
Oct 15, 2020
bnb
reviewed
Oct 15, 2020
Co-authored-by: Tierney Cyren <accounts@bnb.im>
Co-authored-by: Tierney Cyren <accounts@bnb.im>
rodion-arr
approved these changes
Oct 17, 2020
bnb
approved these changes
Oct 28, 2020
There was a problem hiding this comment.
Tested everything locally, seems to work as expected. Great job, @Thiruppathi - additional points for the great styling
A single note before I can merge: could you shift from express-and-handlebar to express-and-handlebars? Note the additional s on handlebars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Example project which uses Express.js to create routes that consume an API.