Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding the same override leads to ??? #435

Closed
oreoshake opened this issue Mar 19, 2020 · 0 comments
Closed

Overriding the same override leads to ??? #435

oreoshake opened this issue Mar 19, 2020 · 0 comments

Comments

@oreoshake
Copy link
Member

@oreoshake oreoshake commented Mar 19, 2020

Bugs

Using override(:foo) with the same :foo multiple times probably shouldn't be supported and feels a bit like wandering into undefined behavior.

Expected outcome

I guess I expected it to raise an error.

Actual outcome

🤷‍♂ didn't dig in

Config

    SecureHeaders::Configuration.override(:preview_policy) do |config|
      #...
    end

    SecureHeaders::Configuration.override(:preview_policy) do |config|
      # a different ...
    end

Generated headers

🤷‍♂ didn't dig in. This feels non-controversial enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant
You can’t perform that action at this time.