Update warning log OpenGL 2.0 to 3.x #8998
Open
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will change the warning message for users when they run an outdated computer or one where it can't detect the GLextensions. 3.x is picked to be easily tracked for developers while not confusing normal users too.
|
Dolphin requires OpenGL 3.1 (or 3.0 + UBO), however this line of code should only fail with OpenGL < 2.0. |
|
I know but for users they'll think they only need 2.0 and i made it 3.x instead of a number to make it obvious for that's the minimum while for developers know it's for OpenGL 2.0 . Not sure how it failed with OpenGL 2.1though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This will change the warning message for users when they run an outdated computer or one where it can't detect the GLextensions.
This is what displayed on a computer with OpenGL 2.1 and DirectX 10.1 version. Pressing either one of these options doesn't work to use Dolphin.
Either way minimum is 3.x for OpenGL.