Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: specify how fs.WriteStream/ReadStreams are created #34188

Closed
wants to merge 1 commit into from
Closed

doc: specify how fs.WriteStream/ReadStreams are created #34188

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jul 3, 2020

Alternative to #33841 (which seems to have stalled out over some objections). This provides an alternative that is hopefully more acceptable.

/cc @addaleax

Co-authored-by: zombieleet zombieleetnca@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc fs labels Jul 3, 2020
@jasnell @zombieleet
doc: specify how fs.WriteStream/ReadStreams are created
6b2b886 
Alternative to nodejs#33841

Co-authored-by: zombieleet <zombieleetnca@gmail.com>
@jasnell jasnell added the author ready label Jul 3, 2020
jasnell added a commit that referenced this issue Jul 5, 2020
@jasnell
doc: specify how fs.WriteStream/ReadStreams are created
e7dadd3 
Alternative to #33841

Co-authored-by: zombieleet <zombieleetnca@gmail.com>

PR-URL: #34188
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell
Copy link
Member Author

@jasnell jasnell commented Jul 5, 2020

Landed in e7dadd3

@jasnell jasnell closed this Jul 5, 2020
MylesBorins pushed a commit that referenced this issue Jul 14, 2020
@jasnell @MylesBorins
doc: specify how fs.WriteStream/ReadStreams are created
c2964b7 
Alternative to #33841

Co-authored-by: zombieleet <zombieleetnca@gmail.com>

PR-URL: #34188
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 14, 2020
Merged
MylesBorins pushed a commit that referenced this issue Jul 16, 2020
@jasnell @MylesBorins
doc: specify how fs.WriteStream/ReadStreams are created
938de33 
Alternative to #33841

Co-authored-by: zombieleet <zombieleetnca@gmail.com>

PR-URL: #34188
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit that referenced this issue Sep 27, 2020
@jasnell @addaleax
doc: specify how fs.WriteStream/ReadStreams are created
a3d18c0 
Alternative to #33841

Co-authored-by: zombieleet <zombieleetnca@gmail.com>

PR-URL: #34188
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit that referenced this issue Sep 28, 2020
@jasnell @addaleax
doc: specify how fs.WriteStream/ReadStreams are created
cef9921 
Alternative to #33841

Co-authored-by: zombieleet <zombieleetnca@gmail.com>

PR-URL: #34188
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax

@lpinca lpinca

Assignees
No one assigned
Labels
author ready doc fs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jasnell @addaleax @lpinca @nodejs-github-bot