Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup-nginx-conf: run nginx on 80/443 #93

Merged
merged 1 commit into from Sep 23, 2020
Merged

setup-nginx-conf: run nginx on 80/443 #93

merged 1 commit into from Sep 23, 2020

Conversation

@mistydemeo
Copy link
Member

@mistydemeo mistydemeo commented Jul 14, 2020

Something surprising was pointed out to me recently: ports under 1024 are no longer privileged as of macOS 10.14, which means non-root processes can now bind to them. I tested and, in fact, this is true.

This means we no longer need launch_socket_server sitting in between Nginx and port 80. We can allow Nginx to bind to those ports directly. Removing one extra tool in the chain is a net benefit to us, and makes things that much simpler!

Copy link

@marwan-at-work marwan-at-work left a comment

Thank you!

@mistydemeo mistydemeo merged commit 2c51c29 into master Sep 23, 2020
1 check passed
1 check passed
macOS
Details
@mistydemeo mistydemeo deleted the promote_nginx_to_80 branch Sep 23, 2020
@mistydemeo mistydemeo restored the promote_nginx_to_80 branch Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.