setup-nginx-conf: run nginx on 80/443 #93
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Something surprising was pointed out to me recently: ports under 1024 are no longer privileged as of macOS 10.14, which means non-root processes can now bind to them. I tested and, in fact, this is true.
This means we no longer need
launch_socket_serversitting in between Nginx and port 80. We can allow Nginx to bind to those ports directly. Removing one extra tool in the chain is a net benefit to us, and makes things that much simpler!